Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_default_fields option to text_format #131

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Oct 24, 2024

As the name says, allows for text formatting a message with the default values included.

I've added a very simple 'Either' type to simplify the code, also using it for the serde implementation.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.19%. Comparing base (8fd210d) to head (f54f011).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
prost-reflect/src/dynamic/serde/ser/mod.rs 80.00% 4 Missing ⚠️
prost-reflect/src/dynamic/text_format/format.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   76.10%   76.19%   +0.09%     
==========================================
  Files          31       31              
  Lines        5473     5470       -3     
==========================================
+ Hits         4165     4168       +3     
+ Misses       1308     1302       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhickman
Copy link
Owner

Thanks for the PR, this looks like a useful flag to support. The changes look good, I'm happy to merge once the tests are passing

@bouk bouk force-pushed the bouk/include-defaults branch from 3ffff40 to f54f011 Compare December 3, 2024 10:01
@bouk
Copy link
Contributor Author

bouk commented Dec 3, 2024

@andrewhickman I've pushed a commit but it's failing again with something that seems unrelated, the lint is also failing for code I didn't touch

@andrewhickman andrewhickman merged commit 33c2074 into andrewhickman:main Dec 3, 2024
2 checks passed
@andrewhickman
Copy link
Owner

andrewhickman commented Dec 3, 2024

CI should be fixed now, thanks for the contribution!

This is now published in version 0.14.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants