Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting button #158

Merged

Conversation

Draculabo
Copy link
Contributor

Because most users only use Chrome extensions and haven't developed them. They may feel confused about how to set up Lumos extensions. So I added a settings button on the Popup page of Lumos to make it easier for users to access the settings page of Lumos.

@andrewnguonly
Copy link
Owner

This is great. Thank you!

@andrewnguonly andrewnguonly changed the base branch from main to 1.0.14 April 7, 2024 01:21
@andrewnguonly
Copy link
Owner

@Draculabo, can you make this change off the 1.0.14 branch? This is the next release branch.

Make sure to run npm run lint to check for lint errors and npx prettier src __tests__ --write to fix the errors, if there are any.

@Draculabo
Copy link
Contributor Author

@Draculabo, can you make this change off the 1.0.14 branch? This is the next release branch.,您可以在 1.0.14 分支上进行此更改吗?这是下一个发布分支。

Make sure to run npm run lint to check for lint errors and npx prettier src __tests__ --write to fix the errors, if there are any.

e

I have already run the command npm run lint, and it looks good.

@andrewnguonly andrewnguonly merged commit 02e2713 into andrewnguonly:1.0.14 Apr 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants