chore(infra): upgrade project for 2020 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed all Buffer deprecated warnings (also in tests). - refactored code to use classes and other es2015 syntax (const; arrow functions; destructuring). Requires Node 6+. - Travis now tests on existing node versions (10/12/13) - use `npm test` in Travis (and removed `"test-travis"` script), as coveralls is not currently integrated (badge removed in previous commits). - replaced depracted istanbul with nyc. renamed script to "coverage". - ensure published package doesn't include "test" folder by defining "files" field in package.json (changelog/license/readme are always included) - upgrade all dependencies to latest versions. - adjusted git to ignore lock files and nyc output.
|
Hey @andrewrk, any chance you can review this? :) |
Travis will call `npm ci` and `npm test` by default
|
ping @andrewrk |
spec is the default reporter. no need to specify it.
|
Fork it |
|
Appreciate the response. |
nalhabash
pushed a commit
to nalhabash/fd-slicer2
that referenced
this pull request
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
closes #3
npm testin Travis (and removed"test-travis"script), as coveralls is not currently integrated (badge removed in previous commits).istanbulwithnyc. renamed script to"coverage".testfolder by defining"files"field inpackage.json(changelog/license/readme are always included)nycoutput.