Feature/anonymous structs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pretty hacky; still gotta clean this up
probably should put them into their own packages to avoid the duplicate struct errors (and in fact I should figure out some way to avoid those duplicates)
...for maps representing structs
...abstracting common logic in recursive descent parser
cleaning up some code too
i was missing Scene and had the types wrong for a few now it's much cleaner with fallthroughs
andreykaipov
force-pushed
the
feature/anonymous-structs
branch
from
20c9477 to
01be6ee
Compare
andreykaipov
force-pushed
the
feature/anonymous-structs
branch
from
01be6ee to
d094af6
Compare
andreykaipov
commented
Jun 19, 2021
Comment on lines
+378
to
+408
| func handleCommonObjects(origin, fieldName string) (string, *keyInfo) { | ||
| if !strings.Contains(fieldName, ".") { | ||
| return "", nil | ||
| } | ||
|
|
||
| // key prefix to manually declared struct in typedefs package | ||
| lookup := map[string][]string{ | ||
| "bounds.": {"Bounds", "The bounding box of the object (source, scene item, etc)."}, | ||
| "crop.": {"Crop", "The crop specification for the object (source, scene item, etc)."}, | ||
| "position.": {"Position", "The position of the object (source, scene item, etc)."}, | ||
| "scale.": {"Scale", "The scaling specification for the object (source, scene item, etc)."}, | ||
| "item.": {"Item", "The item specification for this object."}, | ||
| "font.": {"Font", "The font specification for this object."}, | ||
| "settings.": {"Settings", " "}, | ||
| "stream.settings.": {"Settings", " "}, | ||
| "items.*.": {"Item", "The items for this object."}, | ||
| "filters.*.": {"Filter", "The filters for this object."}, | ||
| } | ||
|
|
||
| for k, vs := range lookup { | ||
| if strings.HasPrefix(fieldName, k) { | ||
| k = strings.TrimSuffix(k, ".") | ||
| s := Qual(typedefQualifier(origin), vs[0]) | ||
| return k, &keyInfo{Type: s, Comment: vs[1]} | ||
| } | ||
| } | ||
|
|
||
| fmt.Printf(" > not handled as a common struct: %s\n", fieldName) | ||
|
|
||
| return "", nil | ||
| } |
There was a problem hiding this comment.
For posterity:
This selection is pretty much the meat of the PR. Here is what's doing the matching and selecting our manually written structs.
|
Closes #8 👀 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.