Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go 1.22 #174

Merged
merged 5 commits into from
Oct 24, 2024
Merged

use go 1.22 #174

merged 5 commits into from
Oct 24, 2024

Conversation

andreykaipov
Copy link
Owner

@andreykaipov andreykaipov commented Oct 4, 2024

CI is failing 🤷

golang.org/x/tools/internal/tokeninternal: cannot compile Go 1.22 code
golang.org/x/mod/semver: cannot compile Go 1.22 code
golang.org/x/tools/internal/event/label: cannot compile Go 1.22 code
golang.org/x/tools/internal/stdlib: cannot compile Go 1.22 code
golang.org/x/tools/internal/aliases: cannot compile Go 1.22 code
golang.org/x/tools/internal/versions: cannot compile Go 1.22 code

@andreykaipov
Copy link
Owner Author

welp, i tried. guess go 1.22 made the flaky functional tests even flakier

@xaionaro
Copy link
Contributor

xaionaro commented Oct 9, 2024

CI is failing 🤷
[...]
welp, i tried. [...]

I understand it happens because of this:
Screenshot from 2024-10-09 16-10-57


You may want to update

- uses: magnetikonline/action-golang-cache@v5

with something like this:
Screenshot from 2024-10-09 16-15-57
(source)

@andreykaipov andreykaipov merged commit 3e3aac7 into main Oct 24, 2024
8 checks passed
@andreykaipov andreykaipov deleted the chore/go1.22 branch October 24, 2024 05:36
@andreykaipov
Copy link
Owner Author

Ah crap, it got auto-merged because I was switched it back to Go 1.20 to confirm I wasn't crazy. I can't imagine why the test would fail when I update the go.mod to Go 1.22. It works for me locally while it fails in the CI. 😕

@xaionaro I don't think it's the CI config. I use go-version-file: go.mod so it picks up whatever is in the go.mod: https://github.com/andreykaipov/goobs/blob/main/.github/workflows/ci.yml#L39-L40

@andreykaipov andreykaipov restored the chore/go1.22 branch October 24, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants