-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser issue when using vite #123
Comments
Hello, @andreyvit |
I managed to get it working in my environment by setting the following configuration. import replace from '@rollup/plugin-replace';
export default defineConfig({
plugins: [
replace({
'process.argv': JSON.stringify([]),
'process.env': JSON.stringify({}),
}),
],
}); |
using patched `json-diff` to avoid the problem with vite see: andreyvit/json-diff#123
using patched `json-diff` to avoid the problem with vite see: andreyvit/json-diff#123
I also had to add the following to the { // ...
'process.platform': '""',
'process.stdout': JSON.stringify(false),
'process.stderr': JSON.stringify(false),
} |
Hi,
I'm using your library, it's great! There's an issue with some newer browser bundlers like vite, which don't like something about the
colors.js
library & blow up when I try to use json-diff.It looks like the calls to
colorize
(the only link to colors.js) here and here are a passthrough; the CLI module calls colorize directly (not via the index module).Would you be amenable to this file being split somehow so the main functionality (the diff function) could be imported from the browser without loading colorize?
Perhaps something like:
Then a browser consumer like me could
and bypass the colorize/colors.js import. I think this would work. Does this sound alright if I can get it working?
The text was updated successfully, but these errors were encountered: