Work around Chrome Autofill issue

android-password-store · Jul 6, 2020 · b6ccab3 · b6ccab3
1 parent 035d3fe
commit b6ccab3
Show file tree

Hide file tree

Showing 6 changed files with 57 additions and 0 deletions.
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -99,6 +99,19 @@
                 android:name="android.accessibilityservice"
                 android:resource="@xml/autofill_config" />
         </service>
+
+        <service
+            android:name=".autofill.oreo.ChromeCompatFix"
+            android:enabled="@bool/enable_chrome_compat_fix"
+            android:permission="android.permission.BIND_ACCESSIBILITY_SERVICE">
+            <intent-filter>
+                <action android:name="android.accessibilityservice.AccessibilityService" />
+            </intent-filter>
+            <meta-data
+                android:name="android.accessibilityservice"
+                android:resource="@xml/oreo_autofill_chrome_compat_fix" />
+        </service>
+
         <service
             android:name=".ClipboardService"
             android:process=":clipboard_service_process" />

diff --git a/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/ChromeCompatFix.kt b/app/src/main/java/com/zeapo/pwdstore/autofill/oreo/ChromeCompatFix.kt
@@ -0,0 +1,21 @@
+/*
+ * Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved.
+ * SPDX-License-Identifier: GPL-3.0-only
+ */
+package com.zeapo.pwdstore.autofill.oreo
+
+import android.accessibilityservice.AccessibilityService
+import android.view.accessibility.AccessibilityEvent
+import com.github.ajalt.timberkt.d
+import kotlin.system.measureTimeMillis
+
+class ChromeCompatFix : AccessibilityService() {
+
+    override fun onAccessibilityEvent(event: AccessibilityEvent) {
+        val time = measureTimeMillis { rootInActiveWindow }
+        d { "${event.packageName} (${AccessibilityEvent.eventTypeToString(event.eventType)}): $time ms" }
+    }
+
+    override fun onInterrupt() {}
+}
+
diff --git a/app/src/main/res/values-v28/bools.xml b/app/src/main/res/values-v28/bools.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <bool name="enable_chrome_compat_fix">true</bool>
+</resources>
diff --git a/app/src/main/res/values/bools.xml b/app/src/main/res/values/bools.xml
@@ -2,4 +2,5 @@
 <resources>
     <bool name="leak_canary_allow_in_non_debuggable_build">true</bool>
     <bool name="enable_accessibility_autofill">true</bool>
+    <bool name="enable_chrome_compat_fix">false</bool>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -275,6 +275,11 @@
     <string name="oreo_autofill_enable_dialog_description">Password Store can offer to fill login forms and even save credentials you enter in apps or on websites.</string>
     <string name="oreo_autofill_enable_dialog_instructions">To enable this feature, tap OK to go to Autofill settings. There, select Password Store from the list and confirm the confirmation prompt with OK.</string>
     <string name="oreo_autofill_enable_dialog_installed_browsers">Autofill support with installed browsers:</string>
+    <string name="oreo_autofill_chrome_compat_fix_summary">Make Autofill more reliable in Chrome</string>
+    <string name="oreo_autofill_chrome_compat_fix_description">This accessibility service makes
+        Autofill apps work more reliably in Chrome. It is only useful if you are also using an
+        Autofill app, but this app need not be Password Store.
+    </string>
 
     <!-- Autofill -->
     <string name="autofill_description">Autofills password fields in apps. Only works for Android versions 4.3 and up. Does not rely on the clipboard for Android versions 5.0 and up.</string>

diff --git a/app/src/main/res/xml/oreo_autofill_chrome_compat_fix.xml b/app/src/main/res/xml/oreo_autofill_chrome_compat_fix.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?><!--
+  ~ Copyright © 2014-2020 The Android Password Store Authors. All Rights Reserved.
+  ~ SPDX-License-Identifier: GPL-3.0-only
+  -->
+<accessibility-service xmlns:android="http://schemas.android.com/apk/res/android"
+    android:accessibilityEventTypes="typeWindowContentChanged|typeViewAccessibilityFocused"
+    android:accessibilityFeedbackType="feedbackVisual"
+    android:accessibilityFlags="flagDefault"
+    android:canRetrieveWindowContent="true"
+    android:description="@string/oreo_autofill_chrome_compat_fix_description"
+    android:notificationTimeout="100"
+    android:packageNames="com.android.chrome,com.chrome.beta,com.chrome.dev,com.chrome.canary"
+    android:summary="@string/oreo_autofill_chrome_compat_fix_summary" />