-
-
Notifications
You must be signed in to change notification settings - Fork 276
[BUG] Versions 1.4.0 and 1.5.0 not updated on F-Droid #648
Comments
AFAICT we're not the ones in charge of the F-Droid metadata. If someone wants to send them a PR with the new package name they're more than welcome to. |
Same on play store. Latest version is 1.3.2 from December 2018. |
You're looking at the wrong listing then. The README has an updated link that takes you to the active version. |
I have "successfully" set up fdroidserver (https://gitlab.com/fdroid/fdroidserver/-/issues/756 should explain the quotes, it's been a bit of a wild ride) and built Password Store with it. Once I've become more familiar with the metadata language, we can submit a PR. |
The following config provides a working F-Droid build. Main findings:
Categories:
- Internet
- Science & Education
License: GPL-3.0-only
WebSite: https://github.com/android-password-store/Android-Password-Store/wiki
SourceCode: https://github.com/android-password-store/Android-Password-Store
IssueTracker: https://github.com/android-password-store/Android-Password-Store/issues
Translation: https://www.transifex.com/android-password-store/android-password-store/
Changelog: https://github.com/android-password-store/Android-Password-Store/releases
AutoName: Password Store
Description: |-
Simple password manager that is compatible with [http://www.passwordstore.org/
pass]: Passwords are stored in simple text files which are encrypted with
OpenPGP.
Requires [[org.sufficientlysecure.keychain]] to encrypt and decrypt passwords.
'''Features:'''
* Clone an existing pass repository
* Initialize a new pass repository
* List the passwords
* Handle the directories as categories
* Decrypt the password files (first line is the password, the rest is extra data)
* Add a new password to the current category (or no category if added at the root)
* Pull and Push changes to the remote repository
* Ability to change remote repository info
RepoType: git
Repo: https://github.com/android-password-store/Android-Password-Store
Builds:
- versionName: 1.7.0-SNAPSHOT
versionCode: 10601
commit: v1.6.0
subdir: app
gradle:
- yes
scandelete:
- app/src/androidTest/assets/private_key |
We ran into this problem at WireGuard as well and our solution was to resort to directly fetching latest releases using the HTTPS method. Try going through the commit history for metadata to how the |
Thanks for the suggestion, this seems like it could work. But there are two more issues:
|
Can we not simply fetch the latest tag from the API?
I don't understand F-Droid at all... |
We can use something like https://api.github.com/repos/android-password-store/Android-Password-Store/releases/latest to get info about the latest release, but F-Droid only allows us to supply two regexes that extract the version name and code out of that. Parsing the version name out of the API response is easy, getting the version code would probably require major trickery (or putting it in the release notes, which are part of the API response).
I will give up on this for now, as I don't understand it either. I will revisit this in time for the 1.7.0 release. |
@FabianHenneke would moving version back into |
Yes, this would help to some extent, but we would also need to keep versionCode, versionName and tag consistent on future releases. For the https://github.com/android-password-store/Android-Password-Store/blob/v1.6.0 tag, they are unfortunately all different. But I can manually add that release and we do this right for v1.7.0. |
What would the right thing be here? I do believe this is correct. I can start taking care to tag the stable version bump rather than the snapshot bump if that's the problem. |
Yes, that is the commit that should have been tagged. It's not a big deal though, I can simply add this version manually. That said, what should I do with the old Password Store listing? I can either delete it entirely (not sure whether this is against fdroid policy though) or rename it to "Password Store (legacy)"? |
Thanks, I'll rework my scripts.
I think we should just rename. Deleting outright seems unnecessary. |
I have drafted a PR that we could submit once v1.7.0 is out: f-droid/fdroiddata@master...FabianHenneke:fhenneke_aps Apart from updating the donation link, I have made some changes to the description. Let me know what you think @msfjarvis @Skrilltrax @zidhuss |
LGTM 👍 |
Not sure if this is still relevant, but I recently found out that there is indeed a way to get a link to the latest release. I use it here to download a precompiled binary in a github action |
Thanks for bringing this up. Unfortunately this seems to apply only to files specifically added to a release and thus would also require extra setup to generate. |
Uppss... |
I just verified that moving the application ID back into |
Nevermind, build is still broken since |
When v1.8.0 rolls around we'll hopefully now be able to get F-Droid builds out as well. |
I have updated my fdroiddata PR: https://gitlab.com/fabian.henneke/fdroiddata/-/commit/ca8039def0ac126832649a62919c6a19eff0d85f |
This looks good to go |
Are we interested in using Fastlane/Triple-T? They seem to be compatible with F-Droid: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6775#note_342115325 |
I wanted to look into using Fastlane and even without it I'll take anything to avoid more interaction with F-Droid than absolutely necessary. Please add the metadata to our repository. |
In order to get 1.8.0 to build on F-Droid, I will have to add a scanignore for the binary version of the Public Suffix List, but that should be fine. Out of curiosity, I also enabled binary verification and ended up with the following diff between our release and the F-Droid build:
Everything here seems related to coroutines, but since all Kotlin language/stdlib versions are tracked in build.gradle, I don't know what to do about these diffs. Any ideas on what might cause this? |
Not really sure why that would be...
Even our transitive dependencies are all using coroutines 1.3.5 |
Could it have something to do with R8? I vaguely recall some coroutine dispatcher related optimizations in R8. I'm not sure how R8 is versioned though. |
R8 is versioned by the Android Gradle Plugin, it's pinned to a specific version and cannot be overriden by transitive dependencies. |
I updated the MR at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6775. Should not be much longer until we are on F-Droid again. |
Don't think we'll be able to get on F-Droid in time for this month's release either, our MRs are just going stale over on F-Droid GitLab :/ |
I have 2 such MRs myself. Waiting in line. But I don't mind. Thanks for pushing it this far. |
The new listing with |
v1.8.1 has been deployed to F-Droid, v1.9.0 shouldn't be too far behind: https://f-droid.org/packages/dev.msfjarvis.aps/ |
Do we know why the Markdown links are not shown correctly? What I also don't know: Are there any manual steps involved in getting this updated to v1.9.0? I guess we'll know in a few days though. |
Hopefully a problem on their end.
Shouldn't be but yeah we'll know in a few days. |
Fixes #648 Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
I asked the maintainers about the missing links. Also, we broke the build (see https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6997), so that may be part of the issue. |
|
The new version has already been picked up: https://gitlab.com/fdroid/fdroiddata/-/commit/cdf2fe025e6b7932575040455cdc4cf854c461bb Due to the switch to CI builds, the new version is also compatible with F-Droid's reproducible builds. I have submitted an MR to get this added: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/6998 |
The old listing is now archived and should vanish from the F-Droid repo soon: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/7028 |
F-Droid lists 1.3.3 as the latest version: https://f-droid.org/packages/com.zeapo.pwdstore/
It seems the build metadata is not up to date. I don't know if this file is maintained by this project, or whether someone from F-Droid keeps it up to date.
The text was updated successfully, but these errors were encountered: