Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Break down PGP Activity into focused sections #776

Merged
merged 52 commits into from
Jun 12, 2020
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
7d70a38
Squashed bringup of new PGP activities
msfjarvis Jun 1, 2020
7f997b0
Fix lint warning
msfjarvis Jun 1, 2020
760ef6b
Code cleanups
msfjarvis Jun 3, 2020
bf059f1
DecryptActivity: fix derp
msfjarvis Jun 3, 2020
f81042c
Cleanup some PgpActivity uses in preparation for removal
msfjarvis Jun 3, 2020
928e9c7
Wire in password edit support
msfjarvis Jun 7, 2020
38eb5de
Improve OpenKeychain binding code
msfjarvis Jun 7, 2020
941d016
Fix clipboard service startup
msfjarvis Jun 7, 2020
258e0ab
Remove LocalBroadcastManager
msfjarvis Jun 7, 2020
182d271
Port GET_KEY_IDS to BasePgpActivity
msfjarvis Jun 8, 2020
f2d4495
Good bye PgpActivity :wave:
msfjarvis Jun 8, 2020
bdb9bd9
UserPreference: fix braindead code
msfjarvis Jun 8, 2020
437c6f1
Codestyle fixups
msfjarvis Jun 8, 2020
8f6f96f
Fix comment
msfjarvis Jun 8, 2020
7262ace
Document BasePgpActivity methods
msfjarvis Jun 8, 2020
206794f
Fix GetKeyIdsActivity
msfjarvis Jun 8, 2020
e5812b1
style
msfjarvis Jun 8, 2020
f5df642
ClipboardService: privatize const
msfjarvis Jun 8, 2020
c892c8d
Merge branch 'master' into refactor/pgp-activity-breakdown
msfjarvis Jun 9, 2020
a2df464
Merge branch 'master' into refactor/pgp-activity-breakdown
msfjarvis Jun 10, 2020
23ccaf8
Refactor clipboard copy flow and improve layout IDs
msfjarvis Jun 10, 2020
503ea97
Rename and move PasswordCreationActivity extras to const vals
msfjarvis Jun 10, 2020
0efffb7
Fix binding fallback
msfjarvis Jun 10, 2020
fec3190
Disallow editing from password fragment
msfjarvis Jun 10, 2020
abea355
Fix decryptAndVerify not being called when finishing without changes
msfjarvis Jun 10, 2020
d5eee35
Merge branch 'master' into refactor/pgp-activity-breakdown
msfjarvis Jun 10, 2020
7c7556f
Apply #843 changes to BasePgpActivity
msfjarvis Jun 10, 2020
01f1d31
Cleanups
msfjarvis Jun 10, 2020
ca6fbac
remove REQUEST_CODE_EDIT
msfjarvis Jun 10, 2020
34b4c4a
Remove unnecessary ClipboardUtils class
msfjarvis Jun 11, 2020
6630417
Move commitChange method to an activity extension
msfjarvis Jun 11, 2020
7aef90f
DecryptActivity: commit changes if there are any
msfjarvis Jun 11, 2020
c9efe62
Commit silently, without a progress dialog
msfjarvis Jun 11, 2020
14ac83b
DecryptActivity: use full path to file in commit message
msfjarvis Jun 11, 2020
4574556
DecryptActivity: ensure we also pass extra content
msfjarvis Jun 11, 2020
820faed
Constify more intent extras
msfjarvis Jun 11, 2020
a6cfde8
Can't stop cleaning up
msfjarvis Jun 11, 2020
603a7fb
strings: capitalize app name in commit messages
msfjarvis Jun 11, 2020
6963d0c
Merge branch 'master' into refactor/pgp-activity-breakdown
msfjarvis Jun 11, 2020
e1f74e4
PasswordCreationActivity: eagerly bind to OpenKeychain
msfjarvis Jun 11, 2020
ba9510a
Address review comments
msfjarvis Jun 12, 2020
4d64860
Fix use of deprecated MasterKeys
msfjarvis Jun 12, 2020
70d5b92
DecryptActivity: set title to filename
msfjarvis Jun 12, 2020
e96e896
Remove dangling comment
msfjarvis Jun 12, 2020
392edb7
Switch to stdlib API for getRelativePath
msfjarvis Jun 12, 2020
c18ce17
Revert "Switch to stdlib API for getRelativePath"
msfjarvis Jun 12, 2020
f5a408e
update CHANGELOG
msfjarvis Jun 12, 2020
8c5c28e
Remove the godforsaken kotlin-android-extensions plugin
msfjarvis Jun 12, 2020
61e0c1b
UserPreference: remove some unused request codes
msfjarvis Jun 12, 2020
02cebd8
Merge branch 'master' into refactor/pgp-activity-breakdown
Jun 12, 2020
5375842
Address Fabian's comments
msfjarvis Jun 12, 2020
5eacee1
Add missing EXTRA_EDITING
msfjarvis Jun 12, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
  • Loading branch information
msfjarvis committed Jun 8, 2020
commit e5812b1cf1e01655f4d32eb7d48012a5c522907a
Original file line number Diff line number Diff line change
@@ -21,9 +21,7 @@ import org.openintents.openpgp.IOpenPgpService2

class GetKeyIdsActivity : BasePgpActivity() {

private val getKeyIds = registerForActivityResult(StartActivityForResult()) {
getKeyIds()
}
private val getKeyIds = registerForActivityResult(StartActivityForResult()) { getKeyIds() }

private val userInteractionRequiredResult = registerForActivityResult(StartIntentSenderForResult()) { result ->
if (result.data == null) {