Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetchat] Add recording audio button #1140

Merged
merged 12 commits into from
Aug 25, 2023
Merged

Conversation

JolandaVerhoef
Copy link
Contributor

See video.

Demonstrating:

  • Cancel on horizontal swipe
  • Only canceling when not too far up
  • Tooltip when tapping the icon
Screen_recording_20230602_160151.mp4

Change-Id: Ib127d6eb63acd78aa1d8f18d3fe27921081a281a
@JolandaVerhoef JolandaVerhoef requested a review from a team as a code owner June 2, 2023 14:03
@riggaroo
Copy link
Collaborator

riggaroo commented Jun 5, 2023

Looks cool! 😎 What about pulsing the size of purple background as you record? Just a suggestion, looks fun as is!

Change-Id: I86fde8685523429f20fbdf8b5521243f4f7295af
…/jetchat-audio-record

Change-Id: Idfbf43f6f893758bca810f12bb2ea5adece08dd1

# Conflicts:
#	Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Change-Id: I06fe2b3b27ea41631d3aaab3722d355feee3cb73
…/jetchat-audio-record

Change-Id: I4cd848d60c64e569af166e420bce7e919632788e
Change-Id: I7e4ce91c26f3563432037dc0807b92cfab8a22aa
…/jetchat-audio-record

Change-Id: I99abaf19043d4861f2a76cec41f0245c6585ec0d
Change-Id: Id89ab0246810bf7696c9899b693fa8fd92cc7c0f
@JolandaVerhoef JolandaVerhoef merged commit bec7726 into main Aug 25, 2023
5 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/jetchat-audio-record branch August 25, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants