-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetchat] Add recording audio button #1140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib127d6eb63acd78aa1d8f18d3fe27921081a281a
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/UserInput.kt
Show resolved
Hide resolved
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
riggaroo
reviewed
Jun 5, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Show resolved
Hide resolved
Looks cool! 😎 What about pulsing the size of purple background as you record? Just a suggestion, looks fun as is! |
Change-Id: I86fde8685523429f20fbdf8b5521243f4f7295af
…/jetchat-audio-record Change-Id: Idfbf43f6f893758bca810f12bb2ea5adece08dd1 # Conflicts: # Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
riggaroo
approved these changes
Jun 5, 2023
bentrengrove
reviewed
Jun 6, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
bentrengrove
reviewed
Jun 6, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/UserInput.kt
Outdated
Show resolved
Hide resolved
Change-Id: I06fe2b3b27ea41631d3aaab3722d355feee3cb73
…/jetchat-audio-record Change-Id: I4cd848d60c64e569af166e420bce7e919632788e
riggaroo
reviewed
Aug 24, 2023
Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/RecordButton.kt
Outdated
Show resolved
Hide resolved
Change-Id: I7e4ce91c26f3563432037dc0807b92cfab8a22aa
…/jetchat-audio-record Change-Id: I99abaf19043d4861f2a76cec41f0245c6585ec0d
Change-Id: Id89ab0246810bf7696c9899b693fa8fd92cc7c0f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See video.
Demonstrating:
Screen_recording_20230602_160151.mp4