Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetlagged] Migrate background AGSL modifier to use Modifier.Node #1231

Merged
merged 7 commits into from
Dec 7, 2023
Merged

[Jetlagged] Migrate background AGSL modifier to use Modifier.Node #1231

merged 7 commits into from
Dec 7, 2023

Conversation

riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Dec 6, 2023 •
edited
Loading

Following our new guidance, the Modifier.yellowBackground() was migrated to use Modifier.Node. https://developer.android.com/jetpack/compose/custom-modifiers#animating_modifier

@riggaroo riggaroo requested a review from a team as a code owner December 6, 2023 10:31
@riggaroo riggaroo requested review from bentrengrove and removed request for florina-muntenescu December 6, 2023 14:00
bentrengrove
bentrengrove approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riggaroo riggaroo merged commit ae9363c into main Dec 7, 2023
1 check passed
@riggaroo riggaroo deleted the riggaroo/background-node branch December 7, 2023 10:30
@riggaroo riggaroo mentioned this pull request Dec 20, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentrengrove bentrengrove bentrengrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riggaroo @bentrengrove