[Jetcaster] Refactor: create domain models #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arriolac
requested review from
florina-muntenescu and
bentrengrove
and removed request for
florina-muntenescu
mlykotom
reviewed
Mar 20, 2024
Jetcaster/core/src/main/java/com/example/jetcaster/core/data/repository/CategoryStore.kt
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/discover/Discover.kt
Outdated
Show resolved
Hide resolved
...ter/core/src/main/java/com/example/jetcaster/core/data/domain/FilterableCategoriesUseCase.kt
Outdated
Show resolved
Hide resolved
...ore/src/main/java/com/example/jetcaster/core/data/domain/GetLatestFollowedEpisodesUseCase.kt
Outdated
Show resolved
Hide resolved
mlykotom
approved these changes
Mar 21, 2024
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/discover/Discover.kt
Outdated
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/discover/Discover.kt
Outdated
Show resolved
Hide resolved
...ter/core/src/main/java/com/example/jetcaster/core/data/domain/FilterableCategoriesUseCase.kt
Show resolved
Hide resolved
Jetcaster/app/src/main/java/com/example/jetcaster/ui/home/HomeViewModel.kt
Outdated
Show resolved
Hide resolved
…over/Discover.kt Co-authored-by: Tomáš Mlynarič <mlykotom@google.com>
arriolac
force-pushed
the
chris/jetcaster/domain_model
branch
from
1a73e92
to
eae0554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following domain layer objects and corresponding test cases:
GetLatestFollowedEpisodesUseCasePodcastCategoryFilterUseCaseFilterableCategoriesUseCaseThis also required creating interfaces for repository objects to enable creating fakes for testing. Introducing these changes improves readability/maintainability of
HomeViewModeland encourages splitting up responsibilities to smaller easily testable contained [domain] objects.