Add search functionality to Jetcaster #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kul3r4
approved these changes
Mar 28, 2024
arriolac
approved these changes
Mar 28, 2024
|
|
||
| @OptIn(ExperimentalCoroutinesApi::class) | ||
| private val searchResultFlow = searchConditionFlow.flatMapLatest { | ||
| podcastStore.searchPodcastByTitleAndCategories(it.keyword, it.selectedCategories) |
There was a problem hiding this comment.
I believe this will still trigger a search when the keyword is the empty string. Do we want that (i.e. still show results if there is no input)? Or should the empty case be handled another way?
There was a problem hiding this comment.
It is an intended behavior to trigger the search with empty string. I expect that all podcasts belonging to the selected category show up when the empty string is input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds search functionality for Jetcaster. More specifically, the following changes are applied: