-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster] Wear - adds navigation to player, cleanup #1316
[Jetcaster] Wear - adds navigation to player, cleanup #1316
Conversation
kul3r4
commented
Apr 4, 2024
•
edited
Loading
edited
- Adds navigation to Player from latest episodes and setting the URI via EpisodePlayer
- Cleanup
- Restructured the Dialog for when the content is empty
8f52132
to
e05d44f
Compare
val volumeViewModel: VolumeViewModel = viewModel(factory = VolumeViewModel.Factory) | ||
|
||
// TODO remove from MediaPlayerScaffold | ||
val snackBarManager: SnackbarManager = SnackbarManager() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these needed or can these be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's leave them for now as I will need to add snackbar messages anyway for when added to queues.
onDismiss = { haveDismissedDialog = true }, | ||
content = { | ||
if (viewState.podcastCategoryFilterResult.topPodcasts.isNotEmpty()) { | ||
items(viewState.podcastCategoryFilterResult.topPodcasts.take(1).size) { index -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block can be simplified to:
val podcast = viewState.podcastCategoryFilterResult.topPodcasts.first()
item {
PodcastContent(
podcast = podcast,
downloadItemArtworkPlaceholder = rememberVectorPainter(
image = Icons.Default.MusicNote,
tintColor = Color.Blue,
),
onClick = {
onTogglePodcastFollowed(podcast)
},
)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, done!
e05d44f
to
85176c0
Compare
85176c0
to
71d7dce
Compare