-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wear] Adds queue screen #1344
[Wear] Adds queue screen #1344
Conversation
e7fae32
to
54d97b9
Compare
}, | ||
onEpisodeItemClick = { navController.navigateToPlayer() }, | ||
onErrorDialogCancelClick = { | ||
navController.popBackStack() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can combine these into a single navigation command. with a popUpTo param.
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Outdated
Show resolved
Hide resolved
if (it.queue.isNotEmpty()) { | ||
QueueScreenState.Loaded(it.queue) | ||
} else { | ||
QueueScreenState.Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually an error? Or should just be an empty queue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to empty. I am using a similar patter to the downloads in the Media Toolkit where you actually do not navigate into the download sections until something is downloaded. So I don't expect the queue to be empty unless there is a failure loadign from the repository.
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Show resolved
Hide resolved
54d97b9
to
f2aec6e
Compare
import com.google.android.horologist.media.ui.screens.entity.DefaultEntityScreenHeader | ||
import com.google.android.horologist.media.ui.screens.entity.EntityScreen | ||
|
||
@Composable fun QueueScreen( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Composable fun QueueScreen( | |
@Composable | |
fun QueueScreen( |
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Outdated
Show resolved
Hide resolved
f2aec6e
to
b018671
Compare
Adds the queue screen and some refactoring