Refactor home to library #1359
Merged
Refactor home to library #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kul3r4
commented
Apr 24, 2024
kul3r4
commented
- Refactor home to use states similar to other screens
- Removed Dialog for when the content is not available in Library as it was causing problem to navigation when dismissing being in a pager. Moreover this avoids flashing problems which have been observed.
arriolac
reviewed
Apr 25, 2024
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/LibraryScreen.kt
Outdated
Show resolved
Hide resolved
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/LibraryScreen.kt
Outdated
Show resolved
Hide resolved
kul3r4
force-pushed
the
jetcaster/all_form_factors
branch
from
ce40d4d
to
f6fc63f
Compare
arriolac
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.