-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using local debug.keystore in all samples. #1362
Conversation
@@ -34,9 +34,9 @@ android { | |||
} | |||
|
|||
signingConfigs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just remove this block altogether? I think Android Studio already defaults to the local key with these parameters for debug builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question is if the benchmark
buildType allows it, but I assume there's default signingConfig
even if it's not defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark requires release build, and release requires a certificate :-/ Not sure how else to work around this
Switching to local debug.keystore to prevent issues with installing debug app on device.