-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jetcaster] Add Type Safety in Navigation for Mobile and TV #1416
base: main
Are you sure you want to change the base?
Conversation
@@ -17,7 +17,7 @@ androidx-core-splashscreen = "1.0.1" | |||
androidx-corektx = "1.13.1" | |||
androidx-glance = "1.1.0" | |||
androidx-lifecycle = "2.8.2" | |||
androidx-navigation = "2.7.7" | |||
androidx-navigation = "2.8.0-beta03" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libs.versions.toml is controlled by the main top level one, and propogated to each sample. Please make changes to that instead of invidually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep this as a draft until the Navigation version stabilizes at 2.8.0. 🥲
) { | ||
composable(Screen.Home.route) { backStackEntry -> | ||
composable<HomeRoute> { backStackEntry -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dturner can you review this pull request for nav type safety?
I have added the Navigation Type-Safety feature to the Mobile and TV platforms.
The WearOS platform is excluded because it uses the Horologist library.