[Jetcaster] Add Type Safety in Navigation for Mobile and TV #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riggaroo
reviewed
Aug 2, 2024
| @@ -17,7 +17,7 @@ androidx-core-splashscreen = "1.0.1" | |||
| androidx-corektx = "1.13.1" | |||
| androidx-glance = "1.1.0" | |||
| androidx-lifecycle = "2.8.2" | |||
| androidx-navigation = "2.7.7" | |||
| androidx-navigation = "2.8.0-beta03" | |||
There was a problem hiding this comment.
The libs.versions.toml is controlled by the main top level one, and propogated to each sample. Please make changes to that instead of invidually.
There was a problem hiding this comment.
I'll keep this as a draft until the Navigation version stabilizes at 2.8.0. 🥲
riggaroo
reviewed
Aug 2, 2024
| ) { | ||
| composable(Screen.Home.route) { backStackEntry -> | ||
| composable<HomeRoute> { backStackEntry -> |
There was a problem hiding this comment.
@dturner can you review this pull request for nav type safety?
riggaroo
requested review from
dturner
and removed request for
arriolac and
bentrengrove
riggaroo
changed the title
dturner
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the Navigation Type-Safety feature to the Mobile and TV platforms.
The WearOS platform is excluded because it uses the Horologist library.