[compose-latest] Update samples on compose-latest branch to Compose 1.3.0-beta01 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll finish this off for Sim once Accompanist is ready |
bentrengrove
force-pushed
the
anomis/compose-latest-1.3.0-beta01
branch
from
25cc0b9
to
345fbda
Compare
alexvanyo
reviewed
Aug 25, 2022
| @@ -148,8 +148,6 @@ fun ConversationContent( | |||
| channelMembers = uiState.channelMembers, | |||
| onNavIconPressed = onNavIconPressed, | |||
| scrollBehavior = scrollBehavior, | |||
| // Use statusBarsPadding() to move the app bar content below the status bar | |||
| modifier = Modifier.statusBarsPadding(), | |||
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatAppBar.kt
Outdated
Show resolved
Hide resolved
| @@ -239,7 +242,6 @@ fun ProfileFab( | |||
| modifier: Modifier = Modifier, | |||
| onFabClicked: () -> Unit = { } | |||
| ) { | |||
|
|
|||
| key(userIsMe) { // Prevent multiple invocations to execute during composition | |||
There was a problem hiding this comment.
I'm pretty sure this key does nothing and was just working around not using derivedStateOf above but I left it in anyway for now
| widthProgress: () -> Float, | ||
| modifier: Modifier | ||
| ) { | ||
| Layout( | ||
| modifier = modifier, | ||
| content = { | ||
| icon() | ||
| Box(modifier = Modifier.alpha(opacityProgress())) { | ||
| Box(modifier = Modifier.graphicsLayer { alpha = opacityProgress() }) { |
There was a problem hiding this comment.
The lambdas being used weren't actually doing any defering because they were being read here in a non-lambda modifier. Fixed by switching to graphicsLayer
| ) { progress -> | ||
| if (progress == ExpandableFabStates.Collapsed) { | ||
| }, | ||
| label = "fab_text_opacity" |
There was a problem hiding this comment.
These labels are for the animation inspector, it's a lint warning not to include them
Comment on lines
-151
to
-152
| // Use statusBarsPadding() to move the app bar content below the status bar | ||
| modifier = Modifier.statusBarsPadding(), |
There was a problem hiding this comment.
Handled automatically by TopAppBar
ricknout
reviewed
Aug 26, 2022
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatAppBar.kt
Outdated
Show resolved
Hide resolved
Jetchat/app/src/main/java/com/example/compose/jetchat/profile/ProfileFragment.kt
Outdated
Show resolved
Hide resolved
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update samples on compose-latest branch to Compose 1.3.0-beta01