Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] Update to collectAsStateWithLifecycle to latest alpha #995

Merged
merged 5 commits into from
Oct 10, 2022

Conversation

astamato
Copy link
Contributor

@astamato astamato commented Oct 8, 2022

No description provided.

@astamato
Copy link
Contributor Author

astamato commented Oct 8, 2022

By adding implementation(libs.androidx.lifecycle.runtime.compose) we're pulling androidx-lifecycle-runtime-compose = "2.6.0-alpha02"

lifecycle:lifecycle-runtime-compose:2.6.0-alpha02 brings beta[!] compose UI:

+--- androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha02
| +--- androidx.annotation:annotation-experimental:1.1.0
| +--- androidx.compose.runtime:runtime:1.0.1 -> 1.3.0-beta03 ()
| +--- androidx.compose.ui:ui:1.0.1 -> 1.3.0-beta03 (
)
| --- androidx.lifecycle:lifecycle-runtime-ktx:2.6.0-alpha02 (*)

This is already happening in Jetchat.

@astamato astamato marked this pull request as ready for review October 10, 2022 07:44
@astamato astamato requested a review from a team as a code owner October 10, 2022 07:44
Jetcaster/README.md Outdated Show resolved Hide resolved
Co-authored-by: Manuel Vivo <mvivo@google.com>
@astamato astamato changed the base branch from main to compose-latest October 10, 2022 22:38
Copy link
Member

@bentrengrove bentrengrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,7 +40,7 @@ private val initialMessages = listOf(
),
Message(
"Taylor Brooks",
"@aliconors Take a look at the `Flow.collectAsState()` APIs",
"@aliconors Take a look at the `Flow.collectAsStateWithLifecycle()` APIs",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you updated this

@astamato astamato merged commit 9dad1d8 into compose-latest Oct 10, 2022
@astamato astamato deleted the as/updates-collectwithlifecycle branch October 10, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants