This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 134
Continuation indent for parameter lists #37
Comments
I absolutely prefer 4. I don't have notes as to why we picked 8. I have a fuzzy memory that the preview version of your style guide said 4 or 8 and we probably just picked one to avoid the "or". |
This was referenced Dec 4, 2017
Since JB also released their guidlines could this be looked into and unified into 4 spaces probably ? |
It already is on `master`.
…On Thu, Jan 11, 2018 at 5:48 AM Lubos Mudrak ***@***.***> wrote:
Since JB also released their guidlines could this be looked into and
unified into 4 spaces probably ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEfDMbq7XqRqTrUAANWRnnXULYnj7ks5tJecLgaJpZM4QhyCF>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current Google style guide requires 8-space indent for wrapped function parameter lists: https://android.github.io/kotlin-guides/style.html#functions
In our style guide, we'd really prefer to require 4-space indents. The reason why 4-space indents work better is primary constructor parameters: we really want to have the same indent for val/var properties defined in the primary constructor and in the body of the class. And to separate the parameters from the body, the wrapped closing parenthesis followed by the opening curly brace (which your current example already shows) works well enough.
Is there any strong reason why you prefer 8-space indents? If not, could you change the guidance?
The text was updated successfully, but these errors were encountered: