Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Include clang-scan-deps in the ndk #1853

Closed
yujincheng08 opened this issue Mar 20, 2023 · 4 comments
Closed

[FR] Include clang-scan-deps in the ndk #1853

yujincheng08 opened this issue Mar 20, 2023 · 4 comments
Assignees

Comments

@yujincheng08
Copy link

Description

Since llvm-16 now supports p1689, if clang-scan-deps is included in the ndk, we can use c++ modules with a newer version of cmake (say 3.26+).

kongy pushed a commit to kongy/llvm_android that referenced this issue Jun 2, 2023
Bug: android/ndk#1853

clang-scan-deps is 88M because the backends for all targets are included in clang-scan-deps.  Linking of backends was added by https://reviews.llvm.org/D103519 - to support PCH.

Change-Id: I9266488056401528ddf96a7434c02177c0242a72
Test: presubmit
@rnikander
Copy link

rnikander commented Feb 24, 2024

I think this should be considered a bug, not a feature request. C++20 modules don't work without clang-scan-deps. Hopefully all you need to do is include executable file in the NDK and we can start using C++20 modules. (If we install our own CMake and Ninja, which is easy.)

CMake Error at C:/Program Files/CMake/share/cmake-3.29/Modules/CMakeTestCXXCompiler.cmake:60 (message):
  The C++ compiler
    "C:/Users/rober/AppData/Local/Android/Sdk/ndk/26.2.11394342/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++.exe"
  is not able to compile a simple test program.
  It fails with the following output:
    Change Dir: 'C:/Users/rober/Workspace/Vulkan/HelloTriangle/app/.cxx/Debug/2f283g26/arm64-v8a/CMakeFiles/CMakeScratch/TryCompile-mcjekv'
    
    Run Build Command(s): C:\Users\rober\AppData\Local\Android\Sdk\cmake\3.22.1\bin\ninja.exe -v cmTC_d6761
    [1/4] C:\Windows\system32\cmd.exe /C ""CMAKE_CXX_COMPILER_CLANG_SCAN_DEPS-NOTFOUND" -format=p1689 -- C:\Users\rober\AppData\Local\Android\Sdk\ndk\26.2
...

@appujee appujee added bug and removed enhancement labels Feb 26, 2024
@DanAlbert
Copy link
Member

This is already in the next compiler, it just hasn't shipped yet.

@github-project-automation github-project-automation bot moved this to Unconfirmed in NDK r27 Feb 27, 2024
@DanAlbert DanAlbert moved this from Unconfirmed to Needs prebuilt update in NDK r27 Feb 27, 2024
@DanAlbert DanAlbert added enhancement and removed bug labels Feb 27, 2024
@github-project-automation github-project-automation bot moved this from Needs prebuilt update to Merged in NDK r27 Mar 12, 2024
@rnikander
Copy link

When is NDK r27 going to be released?

@DanAlbert
Copy link
Member

https://github.com/android/ndk/wiki#ndk-r27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Merged
Development

No branches or pull requests

5 participants