Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] clang frontend crashes on both r26d and canary version #2012

Closed
yujincheng08 opened this issue Apr 11, 2024 · 5 comments
Closed

[BUG] clang frontend crashes on both r26d and canary version #2012

yujincheng08 opened this issue Apr 11, 2024 · 5 comments
Assignees
Labels

Comments

@yujincheng08
Copy link

yujincheng08 commented Apr 11, 2024

Description

https://godbolt.org/z/3cd8nYMh5

Upstream bug

llvm/llvm-project#88400

Commit to cherry-pick

llvm/llvm-project@487967a

Affected versions

r26, Canary

Canary version

28.0.11699160

Host OS

Linux, Mac, Windows

Host OS version

11

Affected ABIs

armeabi-v7a, arm64-v8a, x86, x86_64

@pirama-arumuga-nainar
Copy link
Collaborator

The godbolt repro crashes back to clang 16. This is not a regression, so we will cherry-pick the fix to r27.

@pirama-arumuga-nainar pirama-arumuga-nainar self-assigned this Apr 11, 2024
@DanAlbert
Copy link
Member

Switching godbolt over to the assertions enabled clang shows an assertion failure: https://godbolt.org/z/xh35qaoed

It also fails consistently from clang 16 through HEAD, so not a regression. We might be able to pick up the fix for r27, depending on how invasive it is, but getting the fix into r26e (which isn't currently planned, as there are no regressions against it) seems unlikely.

@DanAlbert
Copy link
Member

(thank you for the quality bug report, btw, that makes things much easier)

@github-project-automation github-project-automation bot moved this to Unconfirmed in NDK r27 Apr 18, 2024
@yujincheng08
Copy link
Author

upstream fixed: llvm/llvm-project@487967a

@github-project-automation github-project-automation bot moved this to Triaged in NDK r28 Apr 29, 2024
@DanAlbert DanAlbert moved this from Unconfirmed to Triaged in NDK r27 Apr 29, 2024
bvlgah pushed a commit to bvlgah/llvm_android_mirror that referenced this issue May 8, 2024
487967af820 [Modules] Don't replace local declarations with external declaration with lower visibility

This change is generated automatically by the script:
  cherrypick_cl.py --sha 487967af82053cd08022635a2ff768385d936c80 --verify-merge --create-cl

Fixes android/ndk#2012

Test: N/A
Change-Id: Ic734e538310c7b766ae35e8e236f433c9351a518
@pirama-arumuga-nainar
Copy link
Collaborator

https://r.android.com/3075606 picks the fix into AOSP toolchain. We'll include the fix in r27.

@DanAlbert DanAlbert moved this from Triaged to Needs prebuilt update in NDK r27 May 9, 2024
@github-project-automation github-project-automation bot moved this from Needs prebuilt update to Merged in NDK r27 Jun 4, 2024
@DanAlbert DanAlbert moved this from Triaged to Merged in NDK r28 Jun 4, 2024
@DanAlbert DanAlbert removed this from NDK r28 Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Merged
Development

No branches or pull requests

3 participants