-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply flowOn(defaultDispatchers) for main-safe. #1238
Open
Jaehwa-Noh
wants to merge
25
commits into
android:main
Choose a base branch
from
Jaehwa-Noh:main-safe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ic3474b86f1af0aaf80c13769223409d7ba070871
Change-Id: Ibadc91344a9ac57fed8449e5174a41e25ec7271e
Change-Id: I3bd11f32b42cb224f4de1b58616c52e0fd982833
Change-Id: I0e050bcecff5d43050103a9a19d0d6b6b31d4ba2
Change-Id: I142352cd418b147e538e8982b4b4dc17fb6b0d53
hoc081098
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. I'll accept your suggestion. |
Change-Id: Iec1e30326807f79753ec68ee10f2ef5f4ad40535
Change-Id: I679f11aa0bcae1d2de54b0373a284f83d0f0c81b
hoc081098
reviewed
Mar 4, 2024
...google/samples/apps/nowinandroid/core/data/repository/CompositeUserNewsResourceRepository.kt
Outdated
Show resolved
Hide resolved
- Style. Change-Id: Iefae14197b1347c7fb00c2d1f754d51cf5419b80
Getting a build error:
|
Change-Id: Ie68dda7a4082d994e2d8d82c1737587f95ab15a0
Change-Id: I185e86f9481bfdb9dea014acb403f00a41edd434
Change-Id: Iee06da9ddded4ed5ba19bbfd5652b4a7a38f4cb9
Change-Id: Idb9fe56112f3764a1d20ae7499b8e9be37674188
Change-Id: I4db56855bb25aa8036b3a2ed5b9c5fd40d8468e1
Change-Id: I0da5c272dcda1355b573fa51746256309fde5d8a
Change-Id: Idff0551cc91d27df7a582f822df62f7b96b907ed
Change-Id: I343a85dfb6d9a101cd6934eceda803c0456184cf
Jaehwa-Noh
changed the title
Apply withContext(defaultDispatchers) for main-safe.
Apply flowOn(defaultDispatchers) for main-safe.
Mar 8, 2024
Change-Id: Icf972886746a53662bae4e70f04f2499c8295236
#1250 This issue had given the clue that how to solve the test fail problems when I was struggling with some tests fail. Thanks. |
Change-Id: Iac1e30f357149fc4c6076d688088f6a54fce73da
Change-Id: I0939a10e2a8779844d59f9f07ef777ad94283811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
I've added withContext(defaultDispatcher) for main-safe at combine.
Fix #1420
DefaultSearchContentsRepository.searchContents
DefaultSearchContentsRepository.getSearchContentsCount
GetFollowableTopicsUseCase.invoke
Flow.mapToUserSearchResult