Remove feature to feature dependencies #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
architecture-features
branch
from
e5fb69e to
5972c05
Compare
3 tasks
mmoczkowski
reviewed
Aug 22, 2023
| @@ -41,6 +45,9 @@ fun NiaNavHost( | |||
| appState: NiaAppState, | |||
| onShowSnackbar: suspend (String, String?) -> Boolean, | |||
| modifier: Modifier = Modifier, | |||
| bookmarksViewModel: BookmarksViewModel = hiltViewModel(), | |||
There was a problem hiding this comment.
This scopes view models to the activity. It seems like quite a fundamental change. I wonder what kind of effect it will have.
SimonMarquis
force-pushed
the
architecture-features
branch
from
d972c20 to
6c73eea
Compare
|
Closing this as I've addressed it in #1271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.