-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alias
instead of id
when specifying plugins
#959
Conversation
What's the benefit of doing this please? It seems to add a lot of noise for no benefit but maybe I'm missing something. |
@dturner Personally, I see the value in it for type safety. One might question why introduce any plugin to TOML in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation @mmoczkowski, makes sense.
Thanks for doing this @McGalanes. The benefit is clear now. |
alias
instead of id
when specifying plugins
@McGalanes |
@dawidhyzy Yes, try disabling your plugins in your project gradle file: |
So that you know did that already. It's not a problem here because it complains about convention plugins defined by my project. |
if you already tried what I said and it still doesn't work I don't understand. Sorry mate |
@dawidhyzy did you ever happen to find a workaround for your issue? I'm experiencing the same problem while trying to add internal convention plugins in this manner and apply them. |
Yes, I think I registered them in the main grade with |
I tried that as well (applying all the local plugins with false) but it was giving the same issue. I have a root project-level plugin that's applied so it might be a race condition with that? |
I think there might be some confusions on what to add in the root project level plugins in previous conversations. I got the same error but was able to resolve after adding my defined plugins to the plugins list in the root project level.
|
No description provided.