-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Android tests on FTL managed device #973
Conversation
Gradle tasks: $./gradlew app:myFtlDeviceDemoDebugAndroidTest TODO: - Add the workflow Ftl.yaml - Add service account JSON file to Gtihub secrets
Let's mark this PR as a draft PR if it's not ready for review. |
gradle/libs.versions.toml
Outdated
@@ -1,7 +1,7 @@ | |||
[versions] | |||
accompanist = "0.28.0" | |||
androidDesugarJdkLibs = "2.0.3" | |||
androidGradlePlugin = "8.1.1" | |||
androidGradlePlugin = "8.2.0-alpha14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to alpha versions of AGP is pretty risky IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand that this version is a prerequisite for enabling FTL managed devices. I'm simply pointing out that it might have unexpected consequences on the overall build, since AGP is applied on almost all modules of this project. 😃
Is there a specific rational behind using a dedicated workflow instead of merging this into |
- rename variable - use Pixel 7 API 33
No specific reason, just to make the CI faster |
This could still be merged into the nowinandroid/.github/workflows/Build.yaml Line 52 in a77d7b6
You said the run time was 19mins. Is it only the test execution time, or did you include the compilation time as well? |
By the way, this PR currently only runs instrumented tests from the |
@@ -33,6 +33,7 @@ dependencyGuard = "0.4.3" | |||
firebaseBom = "32.4.0" | |||
firebaseCrashlyticsPlugin = "2.9.9" | |||
firebasePerfPlugin = "1.4.2" | |||
firebaseTestlab = "0.0.1-alpha05" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a warning, if you ever need to bump this to alpha06 or above, it requires AGP 8.3. mentioning because of previous hesitancy to use unstable releases.
Thank you for submitting this pull request. We have decided not to accept it at this time. |
Run Android test on Firebase test lab device.
Run time: ~19mins.
Gradle tasks: $./gradlew app:myFtlDeviceDemoDebugAndroidTest
Android Studio Hedgehog | 2023.1.1 Canary 14
TODO: