UPDATE: gradle indications were outdated #241
Conversation
replace compile for implementation
| @@ -11,8 +11,8 @@ Consider using the CountingIdlingResource class from the espresso-contrib packag | |||
| Note that the `espresso-idling-resource` dependency is added into the `compile` scope: | |||
There was a problem hiding this comment.
change this to 'implementation' scope too ?
| @@ -11,8 +11,8 @@ Consider using the CountingIdlingResource class from the espresso-contrib packag | |||
| Note that the `espresso-idling-resource` dependency is added into the `compile` scope: | |||
|
|
|||
| ``` | |||
| androidTestCompile 'com.android.support.test.espresso:espresso-core:2.2.2' | |||
| compile 'com.android.support.test.espresso:espresso-idling-resource:2.2.2' | |||
| androidTestImplementation 'com.android.support.test.espresso:espresso-core:2.2.2' | |||
There was a problem hiding this comment.
Looks like the maven artifact references are also out of date. Would you mind updating the references to
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.1'
implementation 'androidx.test.espresso:espresso-idling-resource:3.1.1'
|
Greetings Have updated the Espresso version on doc and gradle. Didn't want to do it with other dependencies because it seems out of the scope. Took the liberty to add the difference between AndroidX and previous. The other Double checked by running the app and the test and both were fine. This is my first `Changes requested', the instruction says I have to push to master, have done it. Do you need me to do something else? |
| @@ -44,5 +44,5 @@ ext { | |||
| coreVersion = "1.1.0-beta01" | |||
| extJUnitVersion = "1.1.0-beta01" | |||
| runnerVersion = "1.1.1-beta01" | |||
There was a problem hiding this comment.
odd. these versions should all be stable, not beta01. Is this branch synced with latest master?
There was a problem hiding this comment.
I assumed master would be the latest, and since the change shouldn't be breaking, just keep my self on master as well.
I feel an example shouldn't have not stable libraries cause it could confuse developer in their learning process.
I'm gonna take look at what you point and will see if I can change the other dependencies while on it.
There was a problem hiding this comment.
Oops, in my local master branch these are stable. I'll look into it
There was a problem hiding this comment.
Please merge in master, I've merged a PR that updated versions to stable
replace compile for implementation