Fixed removal of user info for URLs that contain encoded @ characters #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug occurs when using email addresses encoded as the user (i.e:
rtsp://user%40name:pass@foo.bar/foo.mkv
)The solution is simply to use the
getEncodedAuthority
method instead ofgetAuthority
. This resolves the issue because getAuthority decodes the encoded "@" symbols before splitting, resulting in a malformed URL.Malformed URL example:
rtsp://name:pass/foo.mkv
After the fix, it properly returns:
rtsp://foo.bar/foo.mkv