Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DASH thumbnails cropping the incorrect tile for non-square images #1300

Merged
merged 6 commits into from
May 1, 2024
Merged

Fix DASH thumbnails cropping the incorrect tile for non-square images #1300

merged 6 commits into from
May 1, 2024

Commits on May 1, 2024

  1. Use inputFormat.tileCountHorizontal to calculate tileStartXCoordinate… 

    … for cropping the correct tile from outputBitmap

To find the column of an index in a matrix the formula "column = index % width" should be used, not "column = index % height"

If inputFormat.tileCountVertical was equal to 1 then it would not throw an error, but instead result in the first tile of the bitmap always being returned. If inputFormat.tileCountVertical was larger than 1 then Bitmap.createBitmap() would throw an error as it would attempt to go outside the bounds of outputBitmap

ImageRenderTest has been updated to test for 2x3 images so that tileCountVertical != tileCountHorizontal. These tests passed previously because they were equal, so using tileCountVertical produced the same results as tileCountHorizontal
    @hakonschia @microkatz
    hakonschia authored and microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9ced27a View commit details
    Browse the repository at this point in the history

  2. Revert changes in ImageRenderTest from 3a030da and create a new unit … 

    …test for non square images instead
    @hakonschia @microkatz
    hakonschia authored and microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e27f527 View commit details
    Browse the repository at this point in the history

  3. Create new ImageRenderer in render_tiledImageNonSquare_rendersAllImag… 

    …esToOutput to allow it to use a separate bitmap from the other tests
    @hakonschia @microkatz
    hakonschia authored and microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cf41ba3 View commit details
    Browse the repository at this point in the history

  4. Format with google-java-format

    @microkatz
    microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6d62d34 View commit details
    Browse the repository at this point in the history

  5. Add release note for DASH non-square thumbnail grid fix

    @microkatz
    microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    690bb1a View commit details
    Browse the repository at this point in the history

  6. Updated non-Square thumbnail unit test to contain non-Square thumbnails

    @microkatz
    microkatz committed May 1, 2024
    Configuration menu
    Copy the full SHA
    acc5a3b View commit details
    Browse the repository at this point in the history