Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding interpolated fluid properties #43

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Adding interpolated fluid properties #43

merged 8 commits into from
Oct 24, 2023

Conversation

andrsd
Copy link
Owner

@andrsd andrsd commented Oct 24, 2023

  • Moving Props outside of SinglePhaseFluidProperties
  • Rename Props to State
  • Removing FluidProperties class
  • Adding HDF5/h5pp
  • Adding math::pow
  • Adding utilities to support interpolation
  • Adding InterpolatedFluidProperties

Fluid properties can be given as a grid of values. Then, bicubic interpolation
is created from those values and used for evaluation.
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e5216fc) 97.22% compared to head (1bfe8f1) 97.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   97.22%   97.55%   +0.33%     
==========================================
  Files          23       29       +6     
  Lines        1693     2046     +353     
==========================================
+ Hits         1646     1996     +350     
- Misses         47       50       +3     
Files Coverage Δ
include/Helmholtz.h 99.50% <ø> (ø)
include/InterpolatedFluidProperties.h 100.00% <100.00%> (ø)
include/Numerics.h 100.00% <100.00%> (ø)
include/SinglePhaseFluidProperties.h 100.00% <ø> (ø)
include/Utils.h 100.00% <100.00%> (ø)
python/src/fprops.cpp 100.00% <100.00%> (ø)
src/Helmholtz.cpp 100.00% <100.00%> (ø)
src/IdealGas.cpp 94.11% <100.00%> (ø)
src/Props.cpp 100.00% <100.00%> (ø)
src/SinglePhaseFluidProperties.cpp 100.00% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrsd andrsd merged commit cea334c into main Oct 24, 2023
5 of 6 checks passed
@andrsd andrsd deleted the ipol-fp branch October 24, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant