Skip to content

Commit

Permalink
cluster: add comment clarifying path provider usage
Browse files Browse the repository at this point in the history
Adds a comment clarifying the usage of a path provider at partition
startup time. This is review follow-up to
redpanda-data#20778
  • Loading branch information
andrwng committed Jul 8, 2024
1 parent 240a129 commit 101dd67
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/v/cluster/partition_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ ss::future<consensus_ptr> partition_manager::manage(
raft::keep_snapshotted_log keep_snapshotted_log,
std::optional<cloud_storage::remote_label> remote_label) {
auto guard = _gate.hold();
// NOTE: while the source cluster UUIDs of the path providers will
// ultimately be the same, this is a different path provider than what will
// be used at runtime by the partition. The latter is owned by the archival
// metadata STM and its lifecycle is therefore tied to the partition, which
// hasn't been constructed yet.
cloud_storage::remote_path_provider path_provider(remote_label);
auto dl_result = co_await maybe_download_log(ntp_cfg, rtp, path_provider);
auto& [logs_recovered, clean_download, min_offset, max_offset, manifest, ot_state]
Expand Down

0 comments on commit 101dd67

Please sign in to comment.