Skip to content

Commit

Permalink
cluster: add clarifying comment on setting remote label
Browse files Browse the repository at this point in the history
Adds a comment explaining the condition with which we set a remote
label.

This is follow-up to
redpanda-data#20778
  • Loading branch information
andrwng committed Jul 9, 2024
1 parent 07c515f commit 9007e15
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/v/cluster/topics_frontend.cc
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,12 @@ ss::future<topic_result> topics_frontend::do_create_topic(
bool configured_label_from_manifest
= assignable_config.is_read_replica()
|| assignable_config.is_recovery_enabled();
// We set a remote label if:
// - we haven't got a remote label from the cloud (i.e. this isn't a read
// replica or recovery topic),
// - there is a cluster UUID (always expected),
// - the remote labels feature is active,
// - the config to disable remote labels is False
if (
!configured_label_from_manifest
&& !assignable_config.cfg.properties.remote_label.has_value()
Expand Down

0 comments on commit 9007e15

Please sign in to comment.