Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Making sure that loading it with webpack resolves to non-polyfill whe… #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

activenode
Copy link

…n native support

Loading it with webpack would require additional checkings which are actually not required if we just return global.Intl as it is set to Polyfill anyway when no native support is given.

…n native support

Loading it with webpack would require additional checkings which are actually not required if we just return `global.Intl` as it is set to Polyfill anyway when no native support is given.
@activenode
Copy link
Author

Are you really sure that the given test is correct? Why should the Polyfill according to the Specs deliver something else than the Spec given one?

@activenode
Copy link
Author

@andyearnshaw Can you please check this commit?

@caridy
Copy link
Collaborator

caridy commented Nov 21, 2017

This is a non-backward compatible change, but it might be fine for the next release. The reasoning here is how someone will get a handle on the polyfill if they want to, even if the env supports Intl? they can still do it by setting Intl to undefined, importing this, and grabbing the new global. Maybe we can just offer another file that can be required, to get the inner pieces. Will merge it before next release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants