Stop using Core.Compiler.return_type
#140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there seems to be an issue with broadcast? |
andyferris
reviewed
Feb 26, 2024
src/broadcast.jl
Outdated
| @@ -19,7 +19,7 @@ _data(d::BroadcastedDictionary) = getfield(d, :data) | |||
| sharetokens = _sharetokens(dicts...) | |||
| I = keytype(dicts[1]) | |||
| Ts = Base.Broadcast.eltypes(data) | |||
| T = Core.Compiler.return_type(f, Ts) | |||
| T = Base.promote_op(f, Ts...) | |||
There was a problem hiding this comment.
Maybe this should be Ts.parameters...?
Is that construction inferrable? (If not we can make a pure function with @assume_effects)
There was a problem hiding this comment.
so it turns out that there already is Base.Broadcast.combine_eltypes that does this functionality (except slightly more correctly).
theogf
reviewed
Feb 26, 2024
Co-authored-by: Théo Galy-Fajou <theo.galyfajou@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 80.48% 80.51% +0.03%
==========================================
Files 21 21
Lines 2357 2356 -1
==========================================
Hits 1897 1897
+ Misses 460 459 -1 ☔ View full report in Codecov by Sentry. |
|
should this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.promte_opis a strictly less sketchy version.