Add: Descriptive document title (#49)

* Add: Descriptive document title

* Add: Document title for list pages (exceptions to using Get Page Data module)

* Add: Tests for GetPageData module documentTitle property

* Include: Theatre name in document title for Production instances

server/controllers/productions.js

@@ -98,7 +98,7 @@ exports.list = (req, res, next) => {
 	return Production.list()
 		.then(productions => {
 
-			const page = { title: 'Productions' };
+			const page = { documentTitle: ' | Home', title: 'Productions' };
 
 			res.render('productions/list', Object.assign({ page, productions, alert: getAlert(req) }));
 

server/controllers/theatres.js

@@ -72,7 +72,9 @@ exports.list = (req, res, next) => {
 	return Theatre.list()
 		.then(theatres => {
 
-			const page = { title: 'Theatres' };
+			pageTitle = 'Theatres';
+
+			const page = { documentTitle: ` | ${pageTitle}`, title: pageTitle };
 
 			res.render('theatres/list', Object.assign({ page, theatres, alert: getAlert(req) }));
 

server/lib/get-page-data.js

@@ -6,6 +6,24 @@ const checkIfCreateAction = action => action === 'create';
 
 const getPageTitleText = (model, instance) => instance.pageTitleText || instance[modelNamingPropMap[model]];
 
+const getDocumentTitle = (instance, action, model, title) => {
+
+	let documentTitle = title;
+
+	if (action === 'update') documentTitle = `Edit: ${documentTitle}`;
+
+	if (action !== 'create') {
+
+		if (model === 'production') documentTitle += ` (${instance.theatre.name})`;
+
+		documentTitle += ` (${model})`;
+
+	}
+
+	return ` | ${documentTitle}`;
+
+};
+
 const getAlertText = (model, instance, action) => {
 
 	const instanceText = instance[modelNamingPropMap[model]];
@@ -31,8 +49,11 @@ module.exports = function (instance, action) {
 
 	const isCreateAction = checkIfCreateAction(action);
 
+	const title = isCreateAction ? `New ${model}` : getPageTitleText(model, instance);
+
 	return {
-		title: isCreateAction ? `New ${model}` : getPageTitleText(model, instance),
+		documentTitle: getDocumentTitle(instance, action, model, title),
+		title,
 		modelName: model,
 		modelRoute: `${model}s`,
 		instanceRoute: `/${model}s/${instance.id}`,

spec/server/controllers/productions.spec.js

@@ -441,7 +441,7 @@ describe('Production controller', () => {
 					expect(response._getRenderView()).to.eq('productions/list');
 					expect(response._getRenderData()).to.deep.eq(
 						Object.assign({
-							page: { title: 'Productions' },
+							page: { documentTitle: ' | Home', title: 'Productions' },
 							productions: dataListFixture,
 							alert: alertFixture
 						})

spec/server/controllers/theatres.spec.js

@@ -335,7 +335,7 @@ describe('Theatre controller', () => {
 					expect(response._getRenderView()).to.eq('theatres/list');
 					expect(response._getRenderData()).to.deep.eq(
 						Object.assign({
-							page: { title: 'Theatres' },
+							page: { documentTitle: ' | Theatres', title: 'Theatres' },
 							theatres: dataListFixture,
 							alert: alertFixture
 						})

spec/server/lib/get-page-data.spec.js

@@ -12,9 +12,10 @@ const stubs = {
 const resetStubs = () => {
 
 	stubs.Production = sinon.createStubInstance(Production);
-	stubs.Theatre = sinon.createStubInstance(Theatre);
-
+	stubs.Production.theatre = { name: 'Almeida Theatre' };
 	stubs.Production.errors = {};
+
+	stubs.Theatre = sinon.createStubInstance(Theatre);
 	stubs.Theatre.errors = {};
 
 };
@@ -29,6 +30,67 @@ beforeEach(function () {
 
 describe('Get Page Data module', () => {
 
+	describe('documentTitle property', () => {
+
+		context('create action', () => {
+
+			it('will read \' | New <model>\'', () => {
+				const pageData = subject(stubs.Production, 'create');
+				expect(pageData.documentTitle).to.eq(' | New production');
+			});
+
+		});
+
+		context('update action', () => {
+
+			context('production instance', () => {
+
+				it('will read \' | Edit: <instance> (<theatre name>) (<model>)\'', () => {
+					stubs.Production.title = 'Hamlet';
+					const pageData = subject(stubs.Production, 'update');
+					expect(pageData.documentTitle).to.eq(' | Edit: Hamlet (Almeida Theatre) (production)');
+				});
+
+			});
+
+			context('theatre instance', () => {
+
+				it('will read \' | Edit: <instance> (<model>)\'', () => {
+					stubs.Theatre.name = 'Almeida Theatre';
+					const pageData = subject(stubs.Theatre, 'update');
+					expect(pageData.documentTitle).to.eq(' | Edit: Almeida Theatre (theatre)');
+				});
+
+			});
+
+		});
+
+		context('show action', () => {
+
+			context('production instance', () => {
+
+				it('will read \' | <instance> (<theatre name>) (<model>)\'', () => {
+					stubs.Production.title = 'Hamlet';
+					const pageData = subject(stubs.Production, 'show');
+					expect(pageData.documentTitle).to.eq(' | Hamlet (Almeida Theatre) (production)');
+				});
+
+			});
+
+			context('theatre instance', () => {
+
+				it('will read \' | <instance> (<model>)\'', () => {
+					stubs.Theatre.name = 'Almeida Theatre';
+					const pageData = subject(stubs.Theatre, 'show');
+					expect(pageData.documentTitle).to.eq(' | Almeida Theatre (theatre)');
+				});
+
+			});
+
+		});
+
+	});
+
 	describe('title property', () => {
 
 		context('create action', () => {

views/partials/head.html

@@ -1,4 +1,4 @@
 <head>
-	<title>TheatreBase</title>
+	<title>TheatreBase {{page.documentTitle}}</title>
 	<link rel="stylesheet" href="/main.css">
 </head>