Skip to content

Commit

Permalink
Sync up to commit 8e06553 (NVIDIA#6662)
Browse files Browse the repository at this point in the history
Signed-off-by: Gary Shen <gashen@nvidia.com>

Signed-off-by: Gary Shen <gashen@nvidia.com>
  • Loading branch information
GaryShen2008 authored Sep 30, 2022
1 parent 5664d03 commit fade173
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 17 deletions.
10 changes: 5 additions & 5 deletions scripts/spark2diffs/RapidsConf.diff
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@
< .createWithDefault(ByteUnit.MiB.toBytes(8).toLong)
---
> .createWithDefault(ByteUnit.MiB.toBytes(8))
1633c1635
1636c1638
< |$SPARK_HOME/bin/spark-shell --jars rapids-4-spark_2.12-22.10.0-SNAPSHOT-cuda11.jar \
---
> |${SPARK_HOME}/bin/spark-shell --jars rapids-4-spark_2.12-22.10.0-SNAPSHOT-cuda11.jar \
1688,1692c1690,1693
1691,1695c1693,1696
< // scans not supported in Spark 2.x
< // if (asTable) {
< // printToggleHeader("Scans\n")
Expand All @@ -32,12 +32,12 @@
> printToggleHeader("Scans\n")
> }
> GpuOverrides.scans.values.toSeq.sortBy(_.tag.toString).foreach(_.confHelp(asTable))
1700c1701
1703c1704
< // com.nvidia.spark.rapids.python.PythonConfEntries.init()
---
> com.nvidia.spark.rapids.python.PythonConfEntries.init()
1776,1777d1776
1779,1780d1779
< // Spark 2.x doesn't have access to Cuda in CUDF so just allow
< /*
1793d1791
1796d1794
< */
Original file line number Diff line number Diff line change
Expand Up @@ -1369,7 +1369,9 @@ object RapidsConf {
"alluxio.master.rpc.port(default: 19998) from ALLUXIO_HOME/conf/alluxio-site.properties, " +
"then replace a cloud path which matches spark.rapids.alluxio.bucket.regex like " +
"\"s3://bar/b.csv\" to \"alluxio://0.1.2.3:19998/bar/b.csv\", " +
"and the bucket \"s3://bar\" will be mounted to \"/bar\" in Alluxio automatically.")
"and the bucket \"s3://bar\" will be mounted to \"/bar\" in Alluxio automatically." +
"This config should be enabled when initially starting the application but it " +
"can be turned off and one programmatically after that.")
.booleanConf
.createWithDefault(false)

Expand Down Expand Up @@ -1398,15 +1400,16 @@ object RapidsConf {

val ALLUXIO_REPLACEMENT_ALGO = conf("spark.rapids.alluxio.replacement.algo")
.doc("The algorithm used when replacing the UFS path with the Alluxio path. CONVERT_TIME " +
"and SELECTION_TIME are the valid options. CONVERT_TIME indicates that we do it when " +
"we convert it to a GPU file read, this has extra overhead of creating an entirely new " +
"file index, which requires listing the files and getting all new file info from Alluxio. " +
"SELECTION_TIME indicates we do it when the file reader is selecting the partitions " +
"to process and just replaces the path without fetching the file information again, this " +
"is faster but doesn't update locality information if that were to work with Alluxio.")
"and TASK_TIME are the valid options. CONVERT_TIME indicates that we do it " +
"when we convert it to a GPU file read, this has extra overhead of creating an entirely " +
"new file index, which requires listing the files and getting all new file info from " +
"Alluxio. TASK_TIME replaces the path as late as possible inside of the task. " +
"By waiting and replacing it at task time, it just replaces " +
"the path without fetching the file information again, this is faster " +
"but doesn't update locality information if that has a bit impact on performance.")
.stringConf
.checkValues(Set("CONVERT_TIME", "SELECTION_TIME"))
.createWithDefault("SELECTION_TIME")
.checkValues(Set("CONVERT_TIME", "TASK_TIME"))
.createWithDefault("TASK_TIME")

// USER FACING DEBUG CONFIGS

Expand Down Expand Up @@ -2113,12 +2116,12 @@ class RapidsConf(conf: Map[String, String]) extends Logging {

lazy val getAlluxioReplacementAlgo: String = get(ALLUXIO_REPLACEMENT_ALGO)

lazy val isAlluxioReplacementAlgoSelectTime: Boolean =
get(ALLUXIO_REPLACEMENT_ALGO) == "SELECTION_TIME"

lazy val isAlluxioReplacementAlgoConvertTime: Boolean =
get(ALLUXIO_REPLACEMENT_ALGO) == "CONVERT_TIME"

lazy val isAlluxioReplacementAlgoTaskTime: Boolean =
get(ALLUXIO_REPLACEMENT_ALGO) == "TASK_TIME"

lazy val driverTimeZone: Option[String] = get(DRIVER_TIMEZONE)

lazy val isRangeWindowByteEnabled: Boolean = get(ENABLE_RANGE_WINDOW_BYTES)
Expand Down

0 comments on commit fade173

Please sign in to comment.