Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ip-version and prefix filter attributes to ReserveRandom request #378

Merged
3 commits merged into from
Jun 5, 2024
Merged

Add ip-version and prefix filter attributes to ReserveRandom request #378

3 commits merged into from
Jun 5, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 5, 2024

Description

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost self-assigned this Jun 5, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 5, 2024 •
edited
Loading

Code Climate has analyzed commit 95336c4 and detected 0 issues on this pull request.

View more on Code Climate.

@ghost ghost changed the title Reserve random ip prefix Add ip-version and prefix filter attributes to ReserveRandom request Jun 5, 2024
@ghost ghost marked this pull request as ready for review June 5, 2024 06:12
nachtjasmin
nachtjasmin requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@nachtjasmin nachtjasmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation could be a bit better, but overall I'm fine with it 👍

pkg/ipam/address/address.go Show resolved Hide resolved
pkg/ipam/address/address.go Outdated Show resolved Hide resolved
@ghost ghost force-pushed the reserve-random-ip-prefix branch from 8287913 to 95336c4 Compare June 5, 2024 08:43
@ghost ghost merged commit e3117a5 into main Jun 5, 2024
11 checks passed
@ghost ghost deleted the reserve-random-ip-prefix branch June 5, 2024 11:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nachtjasmin