Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSENG-1746: Use logger of underlying client #381

Merged
merged 1 commit into from
Jun 19, 2024
Merged

SYSENG-1746: Use logger of underlying client #381

merged 1 commit into from
Jun 19, 2024

Conversation

nachtjasmin
Copy link
Contributor

@nachtjasmin nachtjasmin commented Jun 18, 2024 •
edited
Loading

Description

If WithLogger was not called yet, we're now using the underlying logger of the client then.

Closes SYSENG-1746.

Checklist

  • added release notes to Unreleased section in CHANGELOG.md, if user facing change

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 18, 2024 •
edited
Loading

Code Climate has analyzed commit fcc681c and detected 0 issues on this pull request.

View more on Code Climate.

@nachtjasmin nachtjasmin force-pushed the SYSENG-1746/go-anxcloud-client.logger-option-not-used-in-generic-api-client branch from a87e776 to d826c7e Compare June 18, 2024 10:34
@nachtjasmin nachtjasmin marked this pull request as ready for review June 18, 2024 10:34
@nachtjasmin nachtjasmin marked this pull request as draft June 18, 2024 10:35
@nachtjasmin nachtjasmin force-pushed the SYSENG-1746/go-anxcloud-client.logger-option-not-used-in-generic-api-client branch 2 times, most recently from f145357 to f5421cb Compare June 18, 2024 11:35
@nachtjasmin nachtjasmin changed the title SYSENG-1746: Align logger behavior of API with generic client SYSENG-1746: Use logger of underlying client Jun 18, 2024
@nachtjasmin nachtjasmin marked this pull request as ready for review June 18, 2024 11:37
@nachtjasmin nachtjasmin force-pushed the SYSENG-1746/go-anxcloud-client.logger-option-not-used-in-generic-api-client branch from f5421cb to 44117e9 Compare June 18, 2024 11:55
@nachtjasmin nachtjasmin force-pushed the SYSENG-1746/go-anxcloud-client.logger-option-not-used-in-generic-api-client branch from 44117e9 to fcc681c Compare June 18, 2024 12:38
89Q12
89Q12 approved these changes Jun 19, 2024
View reviewed changes
Copy link

@89Q12 89Q12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work :3

@nachtjasmin nachtjasmin merged commit 2b77650 into main Jun 19, 2024
11 checks passed
@nachtjasmin nachtjasmin deleted the SYSENG-1746/go-anxcloud-client.logger-option-not-used-in-generic-api-client branch June 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@89Q12 89Q12 89Q12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nachtjasmin @89Q12