fix: make status field accessible #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 62a9880 and detected 0 issues on this pull request. View more on Code Climate. |
89Q12
approved these changes
Oct 14, 2024
nachtjasmin
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Overall: 👍
Just some small things here and there, but those are adjusted quickly.
I'd also prefer it if we could add integration tests as well (yes, this includes creating a VM). But due to our time constraints, I'm also fine if covering this in a follow-up ticket.
DrPsychick
force-pushed
the
progress-status
branch
from
a05b8c6 to
2ceed2a
Compare
nachtjasmin
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
statusfield of provisioning progress accessible.Checklist
Unreleasedsection in CHANGELOG.md, if user facing change