Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXSVC-1206: dotnet-e5e writes logging messages after output in non-keepalive mode #19

Conversation

nachtjasmin
Copy link
Collaborator

@nachtjasmin nachtjasmin commented Jan 26, 2024

Closes SIANXSVC-1206

To test it

  1. Open the NativeAOT example (cd examples/NativeAOT)

  2. Create a payload.json with the following contents:

    {"context":{"type":"integration-test","async":true,"date":"2024-01-01T00:00:00Z"},"event":{"type":"object","data":{"firstName":"Alexander","lastName":"Windbichler"}}}
  3. Execute the example with the following command:

    dotnet run Hello ++ 0 ++ < payload.json
    

You should see both the logs and the output. In order to check that the redirection works as expected, redirect the stderr to /dev/null, like so:

dotnet run Hello ++ 0 ++ < payload.json 2> /dev/null

The only result is the JSON, with a leading ++. This matches the behaviour of go-e5e.

@nachtjasmin nachtjasmin self-assigned this Jan 26, 2024
@nachtjasmin nachtjasmin force-pushed the bug/SIANXSVC-1206-dotnet-e5e-writes-logging-messages-after-output-in-non-keepalive-mode branch from 4159d2e to dd05c20 Compare January 26, 2024 14:46
@nachtjasmin nachtjasmin added the bug Something isn't working label Jan 29, 2024
@PatrickTaibel
Copy link
Member

Non-keepalive mode now works as intended (tested with our internal test function).

@beachmachine beachmachine force-pushed the bug/SIANXSVC-1206-dotnet-e5e-writes-logging-messages-after-output-in-non-keepalive-mode branch from dd05c20 to b350092 Compare February 2, 2024 13:16
@nachtjasmin nachtjasmin force-pushed the bug/SIANXSVC-1206-dotnet-e5e-writes-logging-messages-after-output-in-non-keepalive-mode branch from b350092 to cbf2fc8 Compare February 2, 2024 16:21
@nachtjasmin nachtjasmin enabled auto-merge (squash) February 2, 2024 16:22
@nachtjasmin nachtjasmin merged commit a63c6e9 into main Feb 2, 2024
2 checks passed
@nachtjasmin nachtjasmin deleted the bug/SIANXSVC-1206-dotnet-e5e-writes-logging-messages-after-output-in-non-keepalive-mode branch February 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants