Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIANXSVC-1060: stability improvments v2 #8

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

PatrickTaibel
Copy link
Member

Second batch of stability improvements. Those were necessary due to additional problems that occurred during testing.
This should be the final one. The main change is that I rewrote our transaction logic to hopefully not contain any race conditions anymore.

@PatrickTaibel PatrickTaibel force-pushed the ptaibel/SIANXSVC-1060_rmux_stability_v2 branch from ce4cd75 to 795f524 Compare October 24, 2023 11:15
@codecov-commenter
Copy link

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (0828cbb) 42.78% compared to head (795f524) 42.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           anexia       #8      +/-   ##
==========================================
- Coverage   42.78%   42.25%   -0.53%     
==========================================
  Files          17       17              
  Lines        1587     1602      +15     
==========================================
- Hits          679      677       -2     
- Misses        857      874      +17     
  Partials       51       51              
Files Coverage Δ
connection/connection_pool.go 78.02% <0.00%> (-1.76%) ⬇️
server.go 16.66% <0.00%> (-0.31%) ⬇️
connection/connection.go 66.91% <46.15%> (+2.37%) ⬆️
client.go 16.92% <0.00%> (-1.62%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beachmachine beachmachine merged commit 053d73b into anexia Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants