Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ja-JP translation #279

Merged
merged 12 commits into from
Nov 1, 2024
Merged

Add ja-JP translation #279

merged 12 commits into from
Nov 1, 2024

Conversation

pap-git
Copy link
Contributor

@pap-git pap-git commented Oct 31, 2024

(´・ω・`)

i hope i didnt mistake

so uh

Some texts are cropped from Google images (with before: option) and an old versions of chrome (2.0.172.31/3.0.197.11/4.0.223)

and some translation that i cant find it are translated by myself

Geckium wizard/settings translated by Me: im still learning england

if theres mistake please tel me!!!

(´・ω・`)

@angelbruni
Copy link
Owner

angelbruni commented Oct 31, 2024

Also gsettings.dtd seems to have conflicts... 🤔

@pap-git
Copy link
Contributor Author

pap-git commented Oct 31, 2024

updated files, i hope it wont cause any issue

@angelbruni
Copy link
Owner

Thank you very much! I will check when I have time.

@angelbruni
Copy link
Owner

I am sorry, but more strings were just pushed, is it possible to update this?

@pap-git
Copy link
Contributor Author

pap-git commented Oct 31, 2024

done 👍

@angelbruni
Copy link
Owner

Thank you, I will check very soon

@pap-git
Copy link
Contributor Author

pap-git commented Oct 31, 2024

now fixed (i think), ill check later (likely 12:00 am or later) if there's new thing

Profile Folder/chrome/locale/ja/dtd/gwizard.dtd Outdated Show resolved Hide resolved
Profile Folder/chrome/locale/ja/dtd/gsettings.dtd Outdated Show resolved Hide resolved
apply=[!!! Âƥƥℓ¥ !!!]
yes=[!!! Ýèƨ !!!]
themeHasNoDescription=このテーマには概要がありません。
builtInTheme=ビルトインテーマ
Copy link
Owner

@angelbruni angelbruni Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builtInTheme seems to be Built-in theme, I think it should probably just be [BUILT-IN] {{themeName}}.
Here's another example of how it looks like in english:
image

apply=[!!! Âƥƥℓ¥ !!!]
yes=[!!! Ýèƨ !!!]
themeHasNoDescription=このテーマには概要がありません。
builtInTheme=[ビルトイン] {{themeName}}
Copy link
Owner

@angelbruni angelbruni Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change fine with you? I had to add brackets to separate BUILT-IN from the theme name and I also had to add {{themeName}} for the theme name to show up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@angelbruni angelbruni merged commit b1cf1bd into angelbruni:main Nov 1, 2024
@angelbruni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants