Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to io_utils.list_files function for instances where column … #42

Merged
merged 12 commits into from
Jan 8, 2024

Conversation

bryjcannon
Copy link
Collaborator

@bryjcannon bryjcannon commented Jan 4, 2024

Addresses issue #41

@bryjcannon bryjcannon linked an issue Jan 4, 2024 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7426002544

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 96.465%

Totals Coverage Status
Change from base Build 6947912800: 0.06%
Covered Lines: 439
Relevant Lines: 451

💛 - Coveralls

@bryjcannon
Copy link
Collaborator Author

I updated the load_folder test before merging - I changed the test as the original version was essentially forcing the error this pr addresses to exist. I think the updated test aligns more with what we want but want to quickly chat before the merge is confirmed.

@alex-l-kong
Copy link
Contributor

@bryjcannon just to be safe, I added more test cases to encompass the specific issues you were running into.

@bryjcannon
Copy link
Collaborator Author

Awesome thanks!

@bryjcannon bryjcannon self-assigned this Jan 8, 2024
@bryjcannon bryjcannon merged commit e2e45e6 into main Jan 8, 2024
4 checks passed
@bryjcannon bryjcannon deleted the list_files_substr_fix branch January 8, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list_files returns inappropriate fov files
4 participants