-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update progress bars #1031
Update progress bars #1031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a tqdm
import suggestion and some units are missing in a few loops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add on top of Sri's comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Looks great |
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
How did you implement your changes
Update the FOV name at start of each code block using
progress_bar.set_postfix(FOV=fov)
.I was able to replicate @HPiyadasa's issue, and it turns out two things could potentially happen with the current code:
Remaining issues
Nothing, I've solved all issues forever.