Don't generate duplicate cluster_id columns if generate_and_save_cluster_masks run twice
#1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srivarra
approved these changes
Jan 24, 2024
…sis into duplicate_cluster_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #1099. Addresses an issue in the merging of
gui_mapandcluster_mapingenerate_and_save_cluster_maskswhere if an existingcluster_idalready exists ingui_map, multiplecluster_idcolumns with variable suffixes get created.How did you implement your changes
We use the
.dropmethod inpandaswitherrors="ignore"to drop thecluster_idcolumn, but only if it exists. This will prevent merging issues.