-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove anything Docker related from the README #1158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the conda env will be the way we support ark from now on, could use a little more info on how to maintain it like we have written up in toffy. For example, an updating the repo section is probably necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alex-l-kong I think we can also remove all docker functionality in this PR such as the Dockerfile, and the docker.yml workflow. What do you think, or we can toss that into another issue?
@srivarra I can remove the Docker badge from this PR. The complete removal of Docker I wanted to save for a different PR. Mostly because I think it'll still be good to have around as legacy. Main goal is to keep this hidden from the instruction manual as much as possible so it doesn't confuse users. |
@alex-l-kong Sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
What is the purpose of this PR?
Closes #1145. Due to issues users have had trying the Docker setup, it's best for the general public not to use this setup.
How did you implement your changes
Remove anything from the
README.md
about Docker setup. Instead, provide detailed instructions for usingconda
environments and./start_jupyter.sh
.