Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anything Docker related from the README #1158

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #1145. Due to issues users have had trying the Docker setup, it's best for the general public not to use this setup.

How did you implement your changes

Remove anything from the README.md about Docker setup. Instead, provide detailed instructions for using conda environments and ./start_jupyter.sh.

@alex-l-kong alex-l-kong self-assigned this Sep 20, 2024
@alex-l-kong alex-l-kong requested a review from cliu72 September 20, 2024 18:44
@alex-l-kong
Copy link
Contributor Author

@cliu72 the failing tests are due to the ongoing pytorch issue (#1150)

@alex-l-kong alex-l-kong requested review from srivarra and camisowers and removed request for cliu72 October 3, 2024 21:07
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the conda env will be the way we support ark from now on, could use a little more info on how to maintain it like we have written up in toffy. For example, an updating the repo section is probably necessary.

Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-l-kong I think we can also remove all docker functionality in this PR such as the Dockerfile, and the docker.yml workflow. What do you think, or we can toss that into another issue?

@alex-l-kong
Copy link
Contributor Author

@alex-l-kong I think we can also remove all docker functionality in this PR such as the Dockerfile, and the docker.yml workflow. What do you think, or we can toss that into another issue?

@srivarra I can remove the Docker badge from this PR. The complete removal of Docker I wanted to save for a different PR. Mostly because I think it'll still be good to have around as legacy. Main goal is to keep this hidden from the instruction manual as much as possible so it doesn't confuse users.

@srivarra
Copy link
Contributor

srivarra commented Oct 4, 2024

@alex-l-kong Sounds good to me!

Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alex-l-kong alex-l-kong added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 9dab65b Oct 4, 2024
18 checks passed
@alex-l-kong alex-l-kong deleted the docker_doc_deprecate branch October 4, 2024 22:14
@srivarra srivarra added the dependencies Pull requests that update a dependency file label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Problem With bash start_docker.sh Command
3 participants