Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save fov images as int16 #644

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Save fov images as int16 #644

merged 2 commits into from
Jul 26, 2022

Conversation

camisowers
Copy link
Contributor

@camisowers camisowers commented Jul 25, 2022

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #521.
Edits the save_fov_images function so the pixel clustering notebook saves overlays images that can be loaded into photoshop.

Remaining issues

Could instead add the saving dtype as a default arg to the function, if that's something you think we'd use.

@camisowers camisowers self-assigned this Jul 25, 2022
@camisowers camisowers requested review from ngreenwald and alex-l-kong and removed request for ngreenwald July 25, 2022 22:54
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, this can be extended to be a more general saving function for tensors of images, but this is fine for now.

@ngreenwald ngreenwald merged commit 3084a09 into master Jul 26, 2022
@ngreenwald ngreenwald deleted the adjust_pixel_overlays branch July 26, 2022 01:25
@srivarra srivarra added the enhancement New feature or request label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow loading of pixel overlays in photoshop
4 participants