-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress bar for the EDA calculation in spatial LDA #680
Conversation
…packages for the time being
Also needed to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to coordinate with Adam about the plan for the local version of ark
@ngreenwald just updated |
What is the purpose of this PR?
Begins addressing #566. Our repo includes a lot of intensive functions, so we'll need to ensure the user receives progress updates for these so they don't get left in the dark.
How did you implement your changes
Use the
tqdm
function in thetqdm.notebook
function.Based on our research and discussion with @ackagel, the only function that needs this for now is
spLDA.preprocessing.compute_topic_modeling
. There are various reasons others don't need them:n
iterationstqdm
short of making a contribution to said package