Next Release v0.4.2 #721
Next Release v0.4.2 #721
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Some minor tweaks.
Will you update requirements.txt to have a comment at the top that says a new release needs to be made anytime the requirements are changed?
Will you also add a comment in the developer docs explaining that code changes aren't automatically propagated into the docker, with the steps that need to be done and the code chunk they'll use. I believe @ackagel mentioned it in his docker update PR
…on how to update ark-analysis within the docker image.
|
Yeah I let Alex know which files to checkout from this branch since the changes to the huggingface dataset file would cause a couple of tests to fail without the adjustment on his end. |
|
Looks good, gonna wait to see if @ackagel's -u update flag fix will require a change to the docker so that we can merge that in before putting out a new release today |
|
Turns out the issue with the docker -u flag was that the docker image was built using the old docker file. Will you add a comment to the docker file saying that any changes will require a new release? Then we'll be good to merge this in |
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Creates a the next release
0.4.2.How did you implement your changes
Adjusted instances of
0.4.1to0.4.2. Added a tiny fix for downloading datasets.Remaining issues
Next step is to create a new release via the releases page.